Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ethpm example solidity files in distribution #1686

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

njgheorghita
Copy link
Contributor

@njgheorghita njgheorghita commented Jul 14, 2020

What was wrong?

Ethpm example solidity contracts were not included in distribution.

How was it fixed?

Added ethpm/examples *.sol to MANIFEST.in

Todo:

Cute Animal Picture

image

@njgheorghita
Copy link
Contributor Author

@marcgarreau So there are no "mission-critical" bugs from what I have tested with the latest release (aka all the ethpm / web3.pm tooling works lovely), since it turns out that none of that tooling depends on the source solidity contracts included in the ethpm-spec examples. In another project (ethpm-cli) I do import those contracts directly from ethpm-spec, and they were missing from the latest release (aside, it's not imperative that I have the raw source contracts in ethpm-cli but it's easier than parsing the ethpm manifest for the source). I've updated MANIFEST.in to include the solidity contracts in the distribution. IMO this probably does not warrant another beta release to validate, but that's just an opinion and I'll happily run another beta release through the ringer.

Copy link
Member

@wolovim wolovim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wolovim wolovim merged commit 47a0a41 into ethereum:master Jul 14, 2020
@njgheorghita njgheorghita deleted the ethpm-manifest-include branch July 14, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants